Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change labels to meetingLabels for clarity #39

Merged
merged 7 commits into from
Nov 19, 2020

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 9, 2020

This changes label to meetingLabel for clarity in the API. For now, I've just effectively changed the name, but if we'd like to add something like additonalMeetingLabels in the future I'd be more than happy to do that work.

@github-actions github-actions bot mentioned this pull request Oct 9, 2020
@github-actions github-actions bot mentioned this pull request Oct 26, 2020
@bnb bnb changed the title feat: change labels to meetingLabel for clarity feat: change labels to meetingLabels for clarity Oct 28, 2020
@bnb
Copy link
Contributor Author

bnb commented Oct 28, 2020

Updated to use meetingLabels rather than meetingLabel. I also reverted a handful of changes that I think were likely unnecessary and unclear, which won't show up in the diff now.

I'm also now using npm@7 and it seems that entirely rewrote package-lock.json and updated the version. Trying to get clarity on if that's backwards-compatible or not 😅

@bnb bnb merged commit a19dcfb into master Nov 19, 2020
@bnb bnb deleted the bnb/label-to-meetingLabel branch November 19, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants