add another test

plaid · Jul 8, 2020 · 1e52247 · 1e52247
1 parent c7fb5ee
commit 1e52247
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/lib/PlaidClient.js b/lib/PlaidClient.js
@@ -14,7 +14,9 @@ const DEFAULT_VERSION = '2019-05-29';
 // Client(String, String, String, String, Object?)
 function Client(configs) {
   if (!R.is(Object, configs)) {
-    throw new Error('Unexpected parameter type. Refer to https://github.com/plaid/plaid-node for how to create a Plaid client.');
+    throw new Error('Unexpected parameter type. ' +
+    'Refer to https://github.com/plaid/plaid-node ' +
+    'for how to create a Plaid client.');
   }
 
   if (R.isNil(configs.clientID)) {

diff --git a/test/PlaidClientTest.js b/test/PlaidClientTest.js
@@ -24,20 +24,28 @@ describe('plaid.Client', () => {
     options: {
       version: '2019-05-29',
     },
-  }
+  };
 
   let pCl;
   beforeEach(() => {
     pCl = new plaid.Client(configs);
   });
 
   describe('constructor', () => {
+    it('throws for invalid parameter', ()  => {
+      expect(() => {
+        plaid.Client('client_id');
+      }).to.throwException(e => {
+        expect(e).to.be.ok();
+        expect(e.message).to.equal('Unexpected parameter type. Refer to https://github.com/plaid/plaid-node for how to create a Plaid client.');
+      });
+    });
+
     it('throws for missing client_id', () => {
       expect(() => {
-        plaid.Client({
-          ...configs,
+        plaid.Client(R.merge(configs, {
           clientID: null,
-        });
+        }));
       }).to.throwException(e => {
         expect(e).to.be.ok();
         expect(e.message).to.equal('Missing Plaid "client_id"');
@@ -46,10 +54,9 @@ describe('plaid.Client', () => {
 
     it('throws for missing secret', () => {
       expect(() => {
-        plaid.Client({
-          ...configs,
+        plaid.Client(R.merge(configs, {
           secret: null,
-        });
+        }));
       }).to.throwException(e => {
         expect(e).to.be.ok();
         expect(e.message).to.equal('Missing Plaid "secret"');
@@ -58,10 +65,9 @@ describe('plaid.Client', () => {
 
     it('throws for invalid environment', () => {
       expect(() => {
-        plaid.Client({
-          ...configs,
+        plaid.Client(R.merge(configs, {
           env: 'gingham',
-        });
+        }));
       }).to.throwException(e => {
         expect(e).to.be.ok();
         expect(e.message).to.equal('Invalid Plaid environment');
@@ -80,18 +86,20 @@ describe('plaid.Client', () => {
     it('succeeds with all arguments', () => {
       expect(() => {
         R.forEachObjIndexed(env => {
-          plaid.Client(configs);
+          plaid.Client(R.merge(configs, {
+            env: env,
+          }));
         }, plaid.environments);
       }).not.to.throwException();
     });
 
     it('succeeds without any options', () => {
       expect(() => {
         R.forEachObjIndexed(env => {
-          plaid.Client({
-            ...configs,
+          plaid.Client(R.merge(configs, {
             options: null,
-          });
+            env: env,
+          }));
         }, plaid.environments);
       }).not.to.throwException();
     });