Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generator that makes
EqualVT
accessible with a uniform signature asEqualMessageVT(proto.Message) bool
.The main motivation is to ease migration from Gogo protobuf by offering a drop-in replacement for
"github.com/gogo/protobuf/proto".Equal
, which uses optimized code where available. With the change in this PR, this can simply be done viaI had added a similar facility when adding
CloneVT
viaCloneGenericVT
. However, with the launch of generics in go1.18, this naming has not aged well. I therefore adopted...Message...
for the variant accepting aproto.Message
, and have also applied this by renamingCloneGenericVT
toCloneMessageVT
(the old variant is still generated for backwards-compatibility, but marked deprecated).