Fix panic when accessing union from invalid input #100
Conversation
There was a problem hiding this comment.
I think this is a great PR, however after adding more tests locally I found out that it still had some problems (that originated in my bad suggestions on #99).
I'm making an updated PR that contains a rebase of your commit, so I think we should close this one.
| @@ -13,9 +13,9 @@ impl<'buf> Table<'buf> { | |||
| buffer: SliceWithStartOffset<'buf>, | |||
| field_offset: usize, | |||
| ) -> Result<Self, ErrorKind> { | |||
| let field_value = u32::from_buffer(buffer, field_offset)?; | |||
| let object_size = u32::from_buffer(buffer, field_offset)?; | |||
There was a problem hiding this comment.
This code is run primarily when a table is accessed from another table. The "field value" is an offset to where the actual table is. I would be up for a better name for this variable, but object_size is not better.
| let offset = self | ||
| .vtable | ||
| .get(2 * vtable_offset..2 * (vtable_offset + 2)) | ||
| .ok_or_else(|| make_error(ErrorKind::InvalidOffset))?; |
There was a problem hiding this comment.
While looking into adding a few extra tests for this, I found out that this should only sometimes be considered an error.
There was a problem hiding this comment.
Thanks a lot! Awesome! Yeap feel free to close this one and focus on the improved version. 🚀
|
Closing as this was included in #102 |
Checklist
Closes #99