Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for docstrings #152

Merged
merged 9 commits into from
Dec 3, 2022
Merged

Implement support for docstrings #152

merged 9 commits into from
Dec 3, 2022

Conversation

TethysSvensson
Copy link
Collaborator

Checklist

  • Updated CHANGELOG.md with relevant changes
  • Added tests for any new/fixed functionality
  • Added/updated documentation for new/changed code
  • Checked that README.md still makes sense (and updated it if necessary)

This finally fixes #4.

@TethysSvensson TethysSvensson changed the title Tethys/docstrings Implement support for docstrings Nov 15, 2022
@TethysSvensson
Copy link
Collaborator Author

It would also be nice to test that the docstrings are actually generated correctly, but I am unsure how to do this. Perhaps it is enough that we can see that they are there in examples/rust/src/monster_generated.rs?

kristoff3r
kristoff3r approved these changes Nov 21, 2022
View reviewed changes
planus-cli/src/ast/convert.rs Show resolved Hide resolved
planus-cli/src/codegen/backend_translation.rs Outdated Show resolved Hide resolved
planus-cli/src/codegen/backend_translation.rs Outdated Show resolved Hide resolved
planus-cli/src/intermediate_language/translation.rs Outdated Show resolved Hide resolved
@TethysSvensson TethysSvensson merged commit 823e7ce into main Dec 3, 2022
@TethysSvensson TethysSvensson deleted the tethys/docstrings branch December 3, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put docstrings in the intermediate language and codegen
2 participants
@TethysSvensson @kristoff3r