Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rule Order Edge Case Between Paragraph Blank Lines and Consecutive Blank Lines #1226

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #1225

There was an issue where running Paragraph Blank Lines when you had something like the following:

Here is a paragraph.  // note the two spaces at the end of this line
  // note the the two spaces at the end of this line
Another paragraph here.

It would add a blank lines between the the two paragraphs. However because Consecutive Blank Lines ran before Paragraph Blank Lines it was unable to clean up those blank lines.

To fix this, the order was changed to make sure Consecutive Blank Lines runs after Paragraph Blank Lines.

Changes Made:

  • Moved the order around so Consecutive Blank Lines runs after Paragraph Blank Lines.

@pjkaufman pjkaufman added the bug Something isn't working label Nov 15, 2024
@pjkaufman pjkaufman self-assigned this Nov 15, 2024
@pjkaufman pjkaufman merged commit e4f7b6a into platers:master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug? Linter creates a bunch of empty lines
1 participant