Make sure to set the db password

[rfay]

Description

Current deploy setup doesn't set the db password. This causes failure in a (non-platformsh, DDEV) environment where there actually is a password.

Related Issue

• setup:install needs to provide the password arg #55

Motivation and Context

DDEV wants to be able to install using this template.

• Magento2 doesn't work with add-on: "Cannot find the main route for Magento. Please add id: magento_route to your routes.yaml" ddev/ddev-platformsh#95

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following list, and put an x in all the boxes that apply. If you're unsure about what any of these mean, don't hesitate to ask. We're here to help!

• I have read the contribution guide
• I have created an issue following the issue guide
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[gilzow]

cc @tylers-username See PR

[rfay]

Pushed this to https://console.platform.sh/rfay/za2egyolyw3m6 and it works fine.

[tylers-username]

@rfay I believe this is good to go. Older versions of Magento required --db-password, when provided, to have a value—it could not be an empty string.

As long as the $database['password'] is defined and is a string, empty string, or null, I believe this code will be fine.

[rfay]

Thanks!

[gilzow]

Moving this to draft for now as it will require additional changes to get it to work properly.

[rfay]

To capture slack conversation,

• https://github.com/platformsh-templates/magento2ce/blob/master/deploy.php#L209 is incorrect/backward.
• composer 1 is still required with current code.

Paul and I discovered that the template hadn't actually been updated from March-August as far as what's delivered to a console template build.

[rfay]

Moved back to ready for review, hope you can take a look @gilzow - thanks!

[gilzow]

closing as this template is now archived