-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit:validate command #906
Open
matthiaz
wants to merge
16
commits into
platformsh:development
Choose a base branch
from
matthiaz:pre-commit-hooks
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. platform app:config-get --local --property hooks.build
e.g. npm run serve
@pjcdawkins do you need further input from me on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally get customers that destroy their data by renaming a container. It's documented, but it gets missed.
This PR adds a new
platform commit:validate
method that can check the commit against a few common mistakes that users do.platform get
will now create apre-commit
hook to launch that validate command.This will protect the user from mistakes, before they push it to us.
Currently, this pre-commit hook warns when it detects:
It will not block the commit, you will get asked if you want to continue. And you can also disable each check individually using
git config
To stop
platform get
from creating the hooks, you can doplatform get --no-create-hooks
(handy for scripts).