Update golangci-lint version

.github/workflows/ci.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.52
+          version: v1.59
 
       - name: Run tests
         run: make test

.golangci.yml

@@ -59,7 +59,7 @@ linters:
     # checks whether HTTP response body is closed successfully
     - bodyclose
     # Go linter that checks if package imports are in a list of acceptable packages
-    - depguard
+    # - depguard
     # Checks assignments with too many blank identifiers (e.g. x, , , _, := f())
     - dogsled
     # Tool for code clone detection
@@ -157,6 +157,6 @@ issues:
       source: "^//go:generate "
 
 # golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
+# https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#how-to-use
 service:
-  golangci-lint-version: 1.52.x # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.59.x # use the fixed version to not introduce new linters unexpectedly

Makefile

@@ -8,7 +8,7 @@ test: generate ## Run unit tests
 
 .PHONY: lint
 lint: ## Run linter
-	command -v golangci-lint >/dev/null || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52
+	command -v golangci-lint >/dev/null || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59
 	golangci-lint run --timeout=10m --verbose
 
 .PHONY: generate

commands/platformify.go

@@ -25,7 +25,7 @@ func NewPlatformifyCmd(assets *vendorization.VendorAssets) *cobra.Command {
 		Short:         fmt.Sprintf("Creates starter YAML files for your %s project", assets.ServiceName),
 		SilenceUsage:  true,
 		SilenceErrors: true,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			answers := models.NewAnswers()
 			answers.Flavor, _ = cmd.Context().Value(FlavorKey).(string)
 			ctx := models.ToContext(cmd.Context(), answers)

commands/validate.go

@@ -23,7 +23,7 @@ func NewValidateCommand(assets *vendorization.VendorAssets) *cobra.Command {
 				"This will check your git repository and validate your files.",
 			assets.ServiceName,
 		),
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			cwd, err := os.Getwd()
 			if err != nil {
 				fmt.Fprintln(

platformifier/generic.go

@@ -30,7 +30,7 @@ type genericPlatformifier struct {
 // Platformify will generate the needed configuration files in the current directory.
 func (p *genericPlatformifier) Platformify(ctx context.Context, input *UserInput) error {
 	assets, _ := vendorization.FromContext(ctx)
-	err := fs.WalkDir(p.templates, ".", func(name string, d fs.DirEntry, walkErr error) error {
+	err := fs.WalkDir(p.templates, ".", func(name string, d fs.DirEntry, _ error) error {
 		if d.IsDir() {
 			return nil
 		}

platformifier/platformifier_test.go

@@ -362,7 +362,7 @@ func (s *PlatformifySuiteTester) TestSuccessfulPlatformifying() {
 			}
 			err := p.Platformify(ctx)
 			// THEN it doesn't return any errors
-			assert.NoError(s.T(), err)
+			assert.NoError(t, err)
 		})
 	}
 }
@@ -436,7 +436,7 @@ func (s *PlatformifySuiteTester) TestPlatformifyingError() {
 			}
 			err := p.Platformify(ctx)
 			// THEN it fails
-			assert.Error(s.T(), err)
+			assert.Error(t, err)
 		})
 	}
 }