[Upsun] Upsun ify a Laravel app should invite users to add the Laravel bridge

[thomasdiluccio]

upsun ify applied on a new Laravel app makes no mention of platformsh/laravel-bridge. It seems those lines are not hit:

platformify/platformifier/laravel.go

Lines 41 to 42 in 19e15b3

	var suggest = "\nPlease use composer to add the Laravel Bridge to your project:\n"
	var composerRequire = "\n composer require platformsh/laravel-bridge\n"

How to reproduce

composer create-project laravel/laravel new-laravel-app

cd new-laravel-app

upsun ify

[gilzow]

can confirm. brand new laravel project, platformsh/bridge is not a listed composer dependency. running upsun ify does not prompt me to add the laravel bridge.

[gilzow]

this appears to be an issue with appRoot at line 31 of laravel.go

What's odd is that ApplicationRoot.Ask determines the correct value:

ApplicationRoot.Ask called!
working directory is: /Users/gilzow/projects/delete/flyio-test-larave
path.dir is: 0x1098c00
Composer path is: /Users/gilzow/projects/delete/flyio-test-larave/composer.json
determined appRoot in application_root.go is: .

so we've determined the correct location at this stage. However, once we create input via answers.ToUserInput() in platformify.go at line 66, input.ApplicationRoot is set back to /:

app root after creating input: /

ah-ha! found it!

@akalipetis in answer.go, when converting the answers into a UserInput object (?), the return of filepath.Join() when a.ApplicationRoot is a . results in a return of / instead of ./ or just ..

Seems like what we want at this point is to have appRoot be a relative directory, correct? Shouldn't we prepend the ApplicationRoot property with a . at line 117? ie

ApplicationRoot:    "." + filepath.Join(string(os.PathSeparator), a.ApplicationRoot),

When doing that, everything works:

working directory is: /Users/gilzow/projects/delete/flyio-test-larave
path.dir is: 0x1098c00
Composer path is: /Users/gilzow/projects/delete/flyio-test-larave/composer.json
determined appRoot in application_root.go is: .
inside of ToUserInput method of Answers
The current value of ApplicationRoot from the answers variable is: . 
The testPath when using Join: ./ 
app root after creating input: ./
application root is: ./
appPath: .
jsonPaths: [composer.json]

Please use composer to add the Laravel Bridge to your project:

    composer require platformsh/laravel-bridge

and even if i move composer.json into a subdirectory:

working directory is: /Users/gilzow/projects/delete/flyio-test-larave
path.dir is: 0x1098c00
Composer path is: /Users/gilzow/projects/delete/flyio-test-larave/foo/composer.json
determined appRoot in application_root.go is: foo

inside of ToUserInput method of Answers
The current value of ApplicationRoot from the answers variable is: foo 
The testPath when using Join: ./foo 
app root after creating input: ./foo
application root is: ./foo
appPath: foo
jsonPaths: [foo/composer.json]

Please use composer to add the Laravel Bridge to your project:

    composer require platformsh/laravel-bridge

[akalipetis]

Thanks a lot @gilzow for the help - the problem was indeed there, but the root cause was in the way we handle root directories in the .Find() command, which affected both Laravel and Django.

It should be fixed in #202