-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to dash 1.0, plus R build #75
Conversation
that might not be covered by a running python dash app
c02d492
to
ec393fe
Compare
Please consider updating package.json with upgraded devDependency
|
Now |
tests/requirements.txt
Outdated
@@ -1,4 +1,3 @@ | |||
dash==0.38.0 | |||
dash[testing]>=1.0.2 | |||
pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to have pytest relevant dependencies here as dash[testing]
will control that
@@ -3,10 +3,9 @@ | |||
# pip install -r requirements.txt | |||
|
|||
chromedriver-binary | |||
dash>=0.38.0 | |||
dash[testing]>=1.0.2 | |||
ipdb | |||
percy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here: percy
adn selenium
will be installed by dash[testing]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For that matter I don't know why we need anything other than dash[testing]
... none of our other repos require chromedriver-binary
, and I don't see ipdb
, flake8
, or pylint
used - do you see any reason we should keep those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not needed, I'm fine to 🔪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
closes #29
Updates tests here to use
dash.testing
, and more standardized build commands.Adding R support turned out to be a lot simpler than #72 made it look - basically, adding in
r_prefix
and using it in thedash-generate-components
call means it all just works ™️ - I added some tests that the right files (R and otherwise) are present after building.This is ready for review, but should not be merged until plotly/dash#801 is merged and released so we can point to a released version of dash in the various
requirements.txt
files.