Merge pull request #340 from plotly/allow-tabs-null-children

Allow tabs null children
plotly · Oct 19, 2018 · 639c826 · 639c826
2 parents a776958 + 85f99f3
commit 639c826
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/dash_core_components/dash_core_components.dev.js b/dash_core_components/dash_core_components.dev.js
diff --git a/dash_core_components/dash_core_components.min.js b/dash_core_components/dash_core_components.min.js
diff --git a/src/components/Tabs.react.js b/src/components/Tabs.react.js
@@ -121,7 +121,7 @@ export default class Tabs extends Component {
 
             const children = this.parseChildrenToArray();
             let value;
-            if (children[0].props.children) {
+            if (children && children[0].props.children) {
                 value = children[0].props.children.props.value || 'tab-1';
             } else {
                 value = 'tab-1';

diff --git a/test/unit/Tabs.test.js b/test/unit/Tabs.test.js
@@ -241,3 +241,11 @@ describe('Tabs can be used 2 ways', () => {
         expect(tabs.state().selected).toEqual('custom-tab-1');
     });
 });
+describe('Tabs can have null children', () => {
+    test('Try to create a Tabs with null children', () => {
+        mount(
+            <Tabs id="tabs">
+            </Tabs>
+        );
+    });
+});