This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Input with type number should return number after value change #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriddyp
reviewed
Nov 2, 2017
src/components/Input.react.js
Outdated
| @@ -21,15 +21,22 @@ export default class Input extends Component { | |||
| render() { | |||
| const { | |||
| fireEvent, | |||
| setProps | |||
| setProps, | |||
| inputType | |||
There was a problem hiding this comment.
I believe that this should be type to match https://github.com/plotly/dash-core-components/pull/100/files#diff-368d71637f90189b9dab46fb80b2c1f1R78
|
This looks great @Madhu94, thank you! Just one small comment about the |
"number" to number
Madhu94
force-pushed
the
cast-types-input-component
branch
from
bf740f2 to
26aa9d0
Compare
|
@chriddyp Is this good to go now ? |
|
Looks great @Madhu94 , thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to close plotly/dash#124. @chriddyp, please let me know if I should do something else here.