This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Improved DatePickerRange #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the onDateChange function to test if provided new dates are different. Closes #209.
The updatemode prop can be 'singledate' or 'bothdates' to specify if you want the callback (setProps) to trigger when selecting one date or when you have selected both (start and end) dates. Wasn't able to write integration test. Closes #152.
This tests if 'bothupdates' as 'updatemode' only triggers after updating both dates.
Added a .click() to lose focus of element, hopefully thereby triggering the callback to fire.
|
Looking forward to this being merged. Thanks for your work @valentijnnieman ! |
|
Any movement on this? Would be great to see this integrated asap. Thanks! |
dash_core_components/metadata.json
Outdated
| @@ -139,73 +139,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "src/components/Confirm.react.js": { | |||
There was a problem hiding this comment.
Curious why this chunk of meta was removed?
There was a problem hiding this comment.
That is curious... I have no idea why it's there in the first place, as there's no Confirm component or anything. Could it be related to the new Confirmation modal?
bpostlethwaite
approved these changes
Jul 9, 2018
chriddyp
reviewed
Jul 10, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,11 @@ | |||
| All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [0.23.1] | |||
| ### Fixed | |||
| - Improved DatePickerRange, fixing issues #209 and 152 | |||
chriddyp
reviewed
Jul 10, 2018
CHANGELOG.md
Outdated
| ### Fixed | ||
| - Improved DatePickerRange, fixing issues #209 and 152 | ||
|
|
||
| ### Added |
chriddyp
reviewed
Jul 10, 2018
| * the DatePicker will update its value | ||
| * as one date is picked. | ||
| */ | ||
| updatemode: PropTypes.oneOf(['singledate', 'bothdates']) |
chriddyp
approved these changes
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the DatePickerRange component, with bugfixes for #209 and #152 .