-
-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
💃 Looks good! |
💃 |
@chriddyp I was trying to pull in plotly 1.39.0 to see if it solved issue plotly/dash#223. I just locally changed
external_url , which looked like the only thing you changed apart from downloading the new JS file and updating the relative_package_path and the version number. Everything deployed fine, but I started getting a new JavaScript error when the map is rendering:
Uncaught ReferenceError: t is not defined I was able to produce this error on your example https://github.com/plotly/dash-recipes/blob/master/dash-plotly-132-histogram-map.py. I only commented out line 10 so as to use the external script. Maybe this is just a local error for me as I was trying to get ahead of your release, but from what I can tell it seems likely this is a real issue. Maybe you want to take a look and ensure you don't get this error before pushing this new version? |
Thanks for reporting @leejt489 ! I'll take a look before releasing |
@chriddyp I'd hazard the guess that it's related to plotly/plotly.js#2787 |
Yep, definitely related to that issue. For the record, referencing plotly 1.39.0 (full version, not minified) produced no errors and did indeed fix plotly/dash#223 ... just in time for my demo tomorrow :) |
Bumping to [email protected] will fix #228 (comment) |
Bumped up to 1.39.1 |
@plotly/dash please review