Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Change package.json scripts to work on windows. #239

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Change package.json scripts to work on windows. #239

merged 2 commits into from
Jul 19, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jul 18, 2018

Had problems running the package.json scripts from my windows machine so I came up with this solution.

  • added copyfiles because cp doesn't work on windows.
  • added cross-env because setting NODE_ENV directly on windows doesn't work.

@bpostlethwaite bpostlethwaite self-requested a review July 18, 2018 19:41
bpostlethwaite
bpostlethwaite approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great yes we can incorporate this into the archetype and eventually the create-dash-component command

cc @valentijnnieman

@bpostlethwaite
Copy link
Member

💃

@T4rk1n T4rk1n merged commit d23db91 into master Jul 19, 2018
@T4rk1n T4rk1n deleted the cross-platform-scripts branch July 19, 2018 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @bpostlethwaite