This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 144
Allow projects to use dcc source directly #723
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fb32835
- produce a /lib output (babel transpiled) of dcc for use in parent p…
9a6b641
changelog
a9bde0b
source map naming tweak
3d7cab8
rc-slider doesn't work with `sideEffects: false`
d4a5d51
remove sideEffects altogether
8a40d72
- break up the lazyloader into individual files
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
"homepage": "https://github.com/plotly/dash-core-components", | ||
"main": "dash_core_components/dash_core_components.min.js", | ||
"scripts": { | ||
"prepublishOnly": "rm -rf lib && babel src --out-dir lib --copy-files", | ||
"start": "webpack-serve ./webpack.serve.config.js --open", | ||
"generator": "node generator/plotly.js", | ||
"lint": "eslint src tests", | ||
|
@@ -48,9 +49,11 @@ | |
"react-markdown": "^4.0.6", | ||
"react-select-fast-filter-options": "^0.2.3", | ||
"react-virtualized-select": "^3.1.3", | ||
"react-resize-detector": "^4.2.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Required for 3rd party build inclusion |
||
"uniqid": "^5.0.3" | ||
}, | ||
"devDependencies": { | ||
"@babel/cli": "^7.4.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Allows using |
||
"@babel/core": "^7.4.0", | ||
"@babel/plugin-proposal-object-rest-spread": "^7.4.0", | ||
"@babel/plugin-syntax-dynamic-import": "^7.2.0", | ||
|
@@ -79,7 +82,6 @@ | |
"prettier": "^1.14.2", | ||
"react": "^16.8.6", | ||
"react-dom": "^16.8.6", | ||
"react-resize-detector": "^4.2.1", | ||
"style-loader": "^0.23.1", | ||
"styled-jsx": "^3.1.1", | ||
"terser-webpack-plugin": "^2.3.0", | ||
|
@@ -88,8 +90,10 @@ | |
"webpack-serve": "^2.0.3" | ||
}, | ||
"files": [ | ||
"/dash_core_components/*{.js,.map}" | ||
"/dash_core_components/*{.js,.map}", | ||
"/lib/**" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include in the published package |
||
], | ||
"sideEffects": false, | ||
"peerDependencies": { | ||
"react": "^16.0.0", | ||
"react-dom": "^16.0.0" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,28 @@ | ||
export default { | ||
datePickerRange: () => | ||
import(/* webpackChunkName: "datepicker" */ '../fragments/DatePickerRange.react'), | ||
datePickerSingle: () => | ||
import(/* webpackChunkName: "datepicker" */ '../fragments/DatePickerSingle.react'), | ||
dropdown: () => | ||
import(/* webpackChunkName: "dropdown" */ '../fragments/Dropdown.react'), | ||
graph: () => | ||
import(/* webpackChunkName: "graph" */ '../fragments/Graph.react'), | ||
markdown: () => | ||
import(/* webpackChunkName: "markdown" */ '../fragments/Markdown.react'), | ||
plotly: () => | ||
Promise.resolve( | ||
window.Plotly || | ||
import(/* webpackChunkName: "plotlyjs" */ 'plotly.js').then( | ||
({default: Plotly}) => { | ||
window.Plotly = Plotly; | ||
return Plotly; | ||
} | ||
) | ||
), | ||
upload: () => | ||
import(/* webpackChunkName: "upload" */ '../fragments/Upload.react'), | ||
}; | ||
export const datePickerRang = () => | ||
import(/* webpackChunkName: "datepicker" */ '../fragments/DatePickerRange.react'); | ||
|
||
export const datePickerSingle = () => | ||
import(/* webpackChunkName: "datepicker" */ '../fragments/DatePickerSingle.react'); | ||
|
||
export const dropdown = () => | ||
import(/* webpackChunkName: "dropdown" */ '../fragments/Dropdown.react'); | ||
|
||
export const graph = () => | ||
import(/* webpackChunkName: "graph" */ '../fragments/Graph.react'); | ||
|
||
export const markdown = () => | ||
import(/* webpackChunkName: "markdown" */ '../fragments/Markdown.react'); | ||
|
||
export const plotly = () => | ||
Promise.resolve( | ||
window.Plotly || | ||
import(/* webpackChunkName: "plotlyjs" */ 'plotly.js').then( | ||
({default: Plotly}) => { | ||
window.Plotly = Plotly; | ||
return Plotly; | ||
} | ||
) | ||
); | ||
|
||
export const upload = () => | ||
import(/* webpackChunkName: "upload" */ '../fragments/Upload.react'); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On prepublish, transpile all source to /lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the css files too! :)