Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Adding drag_value to Slider #884

Closed
wants to merge 36 commits into from
Closed

Conversation

almarklein
Copy link
Contributor

@almarklein almarklein commented Nov 17, 2020

Closes #107

This is an attempt to add a drag_value property to the Slider, such that different callbacks can be applied to the slider being dragged, and the slider being released, as proposed in #107.

Disclaimer: I am not yet familiar with the codebase of this repo, so I just tried to update the new property where the value property was updated.

Todo:

  • The value is initially undefined, and I'm not sure how to initialize it to the same value as value.
  • Also implement this for RangeSlider.
  • update the docstring for updatemode to incorporate the new prop.
  • More docs.

rpkyle and others added 30 commits October 1, 2019 11:21
# Conflicts:
#	DESCRIPTION
# Conflicts:
#	package-lock.json
# Conflicts:
#	.gitignore
#	CHANGELOG.md
#	package-lock.json
#	package.json
@almarklein
Copy link
Contributor Author

cc @emmanuelle

@almarklein almarklein changed the title First stab at adding drag_value to Slider Adding drag_value to Slider Nov 17, 2020
@emmanuelle
Copy link
Contributor

@alexcjohnson @Marc-Andre-Rivet there are still some todo items in this PR but could you please comment whether the PR is going in the right direction?

@alexcjohnson
Copy link
Collaborator

Yes, I think this is reasonable. One possible concern is performance - will there be a problem in very large apps with just having this prop exist even if it isn't used? But I think the hoverData prop in dcc.Graph shows that this is OK.

We should update the docstring for updatemode to incorporate the new prop.

Current changes are only of the src, should this also include changes from after running the built?

No, just src should be changed in this PR. Build artifacts will be updated when we make the next release.

@almarklein almarklein mentioned this pull request Dec 1, 2020
6 tasks
@almarklein
Copy link
Contributor Author

Oh oh, it looks like I did a git screw-up. I'm closing this in favor of #888. Sorry!

@almarklein almarklein closed this Dec 1, 2020
@almarklein almarklein deleted the drag_value branch December 1, 2020 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to have different Outputs react on either a 'drag' or 'mouseup' for a single Slider
5 participants