-
-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
# Conflicts: # DESCRIPTION
# Conflicts: # package-lock.json
- update build artifacts
# Conflicts: # .gitignore # CHANGELOG.md # package-lock.json # package.json
- update build artifacts
Update build artifacts
# Conflicts: # .gitignore
cc @emmanuelle |
@alexcjohnson @Marc-Andre-Rivet there are still some todo items in this PR but could you please comment whether the PR is going in the right direction? |
Yes, I think this is reasonable. One possible concern is performance - will there be a problem in very large apps with just having this prop exist even if it isn't used? But I think the We should update the docstring for
No, just |
Oh oh, it looks like I did a git screw-up. I'm closing this in favor of #888. Sorry! |
Closes #107
This is an attempt to add a
drag_value
property to the Slider, such that different callbacks can be applied to the slider being dragged, and the slider being released, as proposed in #107.Disclaimer: I am not yet familiar with the codebase of this repo, so I just tried to update the new property where the
value
property was updated.Todo:
undefined
, and I'm not sure how to initialize it to the same value asvalue
.updatemode
to incorporate the new prop.