This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
add check that dash was correctly imported and exit with helpful message if failed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really, really great. Would you mind trying to add a test for this? i.e. create a file named Also, let's add this change here: https://github.com/plotly/dash-components-archetype/blob/master/init/%7B%7BpackageNameUnderscored%7D%7D/__init__.py, so that newly made packages get this fix as well. |
|
Yep, good idea regarding the test. I've just added one to a separate file so it can be easily copied to other dash component modules. It checks that |
|
Just created a PR for the component archetype package over in plotly/dash-components-archetype#42 |
chriddyp
reviewed
Mar 30, 2018
| with self.assertRaises(SystemExit) as cm: | ||
| import dash_html_components | ||
|
|
||
| self.assertEqual(cm.exception.code, 1) |
|
this looks good to me. thanks @ned2 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common gotcha that people new to Dash encounter is naming their script 'dash.py' which then shadows the Dash package itself, causing unhappy times. This adds an explicit check that the
dash.developmentattribute exists, which if it doesn't, it's likely this situation has happened, so a more helpful error message is printed to standard error, and the script exits.This catches at least some of the times that this error occurs. If we also change the import order for example code from the Dash User guide to make
from dash.dependencies import Input, State, Outputcome after after the import ofdash_core_componentsthis will then catch a lot more.(This mirrors the same check added in plotly/dash-core-components#177)