This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix setProps when IDs aren't provided #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
construct paths on-the-fly while recursing through the tree.
chriddyp
changed the title
| addIndex(map)( | ||
| (component, i) => createContainer(component, concat(path, ['props', 'children', i])), | ||
| components | ||
| ) : createContainer(components, concat(path, ['props', 'children'])); |
There was a problem hiding this comment.
Non-🚫 but to my eye ramda makes this much harder to read, vs vanilla
components.map((component, i) =>
createContainer(component, concat(path, ['props', 'children', i]))
)
alexcjohnson
approved these changes
Apr 20, 2019
|
@chriddyp this is awesome (my 💃 stands BTW, despite the extra discussion). But @byronz merged some of the |
|
Yeah - I think I'll follow up with a PR that cleans up some of the DCC logic. I think that the |
chriddyp
added a commit
that referenced
this pull request
Apr 22, 2019
provide valid setProps for all components, even if they don't have an ID construct paths on-the-fly while recursing through the tree.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165