Merge pull request #450 from plotly/remove-keywords

Use all python keywords when checking if prop name is valid

.circleci/requirements/dev-requirements-py37.txt

@@ -1,4 +1,4 @@
-dash_core_components>=0.35.1
+dash_core_components==0.35.1
 dash_html_components==0.12.0rc3
 dash-flow-example==0.0.3
 dash-dangerously-set-inner-html

.circleci/requirements/dev-requirements.txt

@@ -1,4 +1,4 @@
-dash_core_components>=0.35.1
+dash_core_components==0.35.1
 dash_html_components>=0.12.0rc3
 dash_flow_example==0.0.3
 dash-dangerously-set-inner-html

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.28.7 - 2018-11-05
+## Fixed
+- Component generation now uses the same prop name black list in all supported Python versions. Closes [#361](https://github.com/plotly/dash/issues/361). [#450](https://github.com/plotly/dash/pull/450)
+
 ## 0.28.6 - 2018-11-05
 ## Fixed
 - `Dash.registered_paths` changed to a `collections.defaultdict(set)`, was appending the same package paths on every index. [#443](https://github.com/plotly/dash/pull/443)

dash/development/_all_keywords.py

@@ -0,0 +1,44 @@
+# This is a set of Python keywords that cannot be used as prop names.
+# Keywords for a particular version are obtained as follows:
+# >>> import keyword
+# >>> keyword.kwlist
+
+kwlist = set([
+    'and',
+    'elif',
+    'is',
+    'global',
+    'as',
+    'in',
+    'if',
+    'from',
+    'raise',
+    'for',
+    'except',
+    'nonlocal',
+    'pass',
+    'finally',
+    'print',
+    'import',
+    'True',
+    'None',
+    'return',
+    'exec',
+    'await',
+    'else',
+    'break',
+    'not',
+    'with',
+    'class',
+    'assert',
+    'False',
+    'yield',
+    'try',
+    'while',
+    'continue',
+    'del',
+    'async',
+    'or',
+    'def',
+    'lambda'
+])

dash/development/base_component.py

@@ -2,7 +2,7 @@
 import copy
 import os
 import inspect
-import keyword
+from ._all_keywords import kwlist
 
 
 def is_number(s):
@@ -380,7 +380,7 @@ def __repr__(self):
           '{:s}=Component.UNDEFINED'.format(p))
          for p in prop_keys
          if not p.endswith("-*") and
-         p not in keyword.kwlist and
+         p not in kwlist and
          p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
     )
 

dash/version.py

@@ -1 +1 @@
-__version__ = '0.28.6'
+__version__ = '0.28.7'