Skip to content

Commit

Permalink
Merge pull request #484 from plotly/extract-meta-mute-props
Browse files Browse the repository at this point in the history
Mute dash related missing props docstring from extract-meta warnings.
  • Loading branch information
T4rk1n authored Dec 7, 2018
2 parents b0ea2f4 + 5fe9d45 commit 85e4863
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.32.1 - 2018-12-07
## Changed
- Muted dash related missing props docstring from extract-meta warnings [#484](https://github.com/plotly/dash/pull/484)

## 0.32.0 - 2018-12-07
## Added
- Support for .map file extension and dynamic (on demand) loading [#478](https://github.com/plotly/dash/pull/478)
Expand Down
3 changes: 2 additions & 1 deletion dash/extract-meta.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ function writeError(msg, filePath) {
}

function checkWarn(name, value) {
if (value.length < 1) {
const excluded = ['setProps', 'id', 'className', 'style', 'dashEvents', 'fireEvent'];
if (value.length < 1 && !excluded.includes(name)) {
process.stderr.write(`\nDescription for ${name} is missing!\n`)
}
}
Expand Down
2 changes: 1 addition & 1 deletion dash/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.32.0'
__version__ = '0.32.1'

0 comments on commit 85e4863

Please sign in to comment.