Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

support for oracle db #322

Closed
chriddyp opened this issue Dec 14, 2017 · 2 comments
Closed

support for oracle db #322

chriddyp opened this issue Dec 14, 2017 · 2 comments

Comments

@chriddyp
Copy link
Member

I've been following some threads in https://github.com/oracle/node-oracledb for the last year or two, and it looks like native binaries are finally available! oracle/node-oracledb#18 (comment). As far as I recall, this was one of the blockers for supporting oracledb in this client.

@chriddyp
Copy link
Member Author

If anyone in the community would like to take this on, see #266

n-riesco added a commit that referenced this issue May 17, 2018
* Implemented connector to Oracle based on node-oracledb.

* Implemented a pool of clients to ensure all the request from a
  connector share the same client. For more details, see
  `backend/persistent/datastores/pool.js`.

* Upgraded to [email protected] and node@8, so that:
  - both node and electron have ABI 57 (for which node-oracledb provides
    binaries)
  - unable to use [email protected] due to issue resulting in a empty window
    at some startups

* Added Dockerfile and npm scripts to build and launch a container with
  an Oracle Express database setup for testing.

* Ensure connector failures are logged.

* Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md`
  for the requirements to run these tests.

* Updated documentation in `CONTRIBUTING.md`.

Closes #322
n-riesco added a commit that referenced this issue May 17, 2018
* Implemented connector to Oracle based on node-oracledb.

* Implemented a pool of clients to ensure all the request from a
  connector share the same client. For more details, see
  `backend/persistent/datastores/pool.js`.

* Upgraded to [email protected] and node@8, so that:
  - both node and electron have ABI 57 (for which node-oracledb provides
    binaries)
  - unable to use [email protected] due to issue resulting in a empty window
    at some startups

* Added Dockerfile and npm scripts to build and launch a container with
  an Oracle Express database setup for testing.

* Ensure connector failures are logged.

* Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md`
  for the requirements to run these tests.

* Updated documentation in `CONTRIBUTING.md`.

Closes #322
n-riesco added a commit that referenced this issue May 18, 2018
* Implemented connector to Oracle based on node-oracledb.

* Implemented a pool of clients to ensure all the request from a
  connector share the same client. For more details, see
  `backend/persistent/datastores/pool.js`.

* Upgraded to [email protected] and node@8, so that:
  - both node and electron have ABI 57 (for which node-oracledb provides
    binaries)
  - unable to use [email protected] due to issue resulting in a empty window
    at some startups

* Added Dockerfile and npm scripts to build and launch a container with
  an Oracle Express database setup for testing.

* Ensure connector failures are logged.

* Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md`
  for the requirements to run these tests.

* Updated documentation in `CONTRIBUTING.md`.

Closes #322
n-riesco added a commit that referenced this issue May 24, 2018
* Implemented connector to Oracle based on node-oracledb.

* Implemented a pool of clients to ensure all the request from a
  connector share the same client. For more details, see
  `backend/persistent/datastores/pool.js`.

* Upgraded to [email protected] and node@8, so that:
  - both node and electron have ABI 57 (for which node-oracledb provides
    binaries)
  - unable to use [email protected] due to issue resulting in a empty window
    at some startups

* Added Dockerfile and npm scripts to build and launch a container with
  an Oracle Express database setup for testing.

* Ensure connector failures are logged.

* Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md`
  for the requirements to run these tests.

* Updated documentation in `CONTRIBUTING.md`.

Closes #322
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants