-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geom_boxplot() improvements #1514
base: master
Are you sure you want to change the base?
Conversation
This should wait until we upgrade to plotly.js 1.52, then we can use the new 'pre-computed' feature of the box trace. |
Hello, would you know how we can apply these changes in the python library? |
|
I also noticed that this throw an error when you consider #1603 > library(plotly)
>
> plot <- ggplot(diamonds, aes(cut, price)) +
+ geom_boxplot() +
+ scale_y_continuous(trans = "sqrt", limits = c(0, 25000))
>
> ggplotly(plot)
Error in mm2pixels(convert(u, "mm")) : Unit must be in millimeters |
This changes the default behaivor of ggplotly() to render
geom_boxplot()
as low-level polygons rather than plotly.js box traces. As result, we'll be able to exactly replicate the ggplot2 result in many more cases. A list of relevant issues this PR should close: #1484, #1241, #1114, #1098, #866, #697, #706BTW, for those who want the old-behavior (which one might want in order to keep the tooltip behavior the same), you can change
geom_boxplot()
togeom_boxplot2()
TODO: