more role removal

plotly · Jan 20, 2021 · 65da615 · 65da615
1 parent 6b43933
commit 65da615
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/src/components/colorbar/attributes.js b/src/components/colorbar/attributes.js
@@ -18,7 +18,6 @@ module.exports = overrideAll({
 // TODO: only right is supported currently
 //     orient: {
 //         valType: 'enumerated',
-//         role: 'info',
 //         values: ['left', 'right', 'top', 'bottom'],
 //         dflt: 'right',
 //         description: [

diff --git a/src/plot_api/plot_schema.js b/src/plot_api/plot_schema.js
@@ -63,7 +63,7 @@ exports.get = function() {
     return {
         defs: {
             valObjects: valObjectMeta,
-            metaKeys: UNDERSCORE_ATTRS.concat(['description', 'role', 'editType', 'impliedEdits']),
+            metaKeys: UNDERSCORE_ATTRS.concat(['description', 'editType', 'impliedEdits']),
             editType: {
                 traces: editTypes.traces,
                 layout: editTypes.layout
@@ -600,14 +600,14 @@ function getFramesAttributes() {
 }
 
 function formatAttributes(attrs) {
-    mergeValTypeAndRole(attrs);
+    mergeValType(attrs);
     formatArrayContainers(attrs);
     stringify(attrs);
 
     return attrs;
 }
 
-function mergeValTypeAndRole(attrs) {
+function mergeValType(attrs) {
     function makeSrcAttr(attrName) {
         return {
             valType: 'string',
@@ -622,17 +622,12 @@ function mergeValTypeAndRole(attrs) {
     function callback(attr, attrName, attrs) {
         if(exports.isValObject(attr)) {
             if(attr.valType === 'data_array') {
-                // all 'data_array' attrs have role 'data'
-                attr.role = 'data';
                 // all 'data_array' attrs have a corresponding 'src' attr
                 attrs[attrName + 'src'] = makeSrcAttr(attrName);
             } else if(attr.arrayOk === true) {
                 // all 'arrayOk' attrs have a corresponding 'src' attr
                 attrs[attrName + 'src'] = makeSrcAttr(attrName);
             }
-        } else if(isPlainObject(attr)) {
-            // all attrs container objects get role 'object'
-            attr.role = 'object';
         }
     }
 
@@ -651,7 +646,6 @@ function formatArrayContainers(attrs) {
 
         attrs[attrName] = { items: {} };
         attrs[attrName].items[itemName] = attr;
-        attrs[attrName].role = 'object';
     }
 
     exports.crawl(attrs, callback);

diff --git a/src/traces/barpolar/attributes.js b/src/traces/barpolar/attributes.js
@@ -24,7 +24,6 @@ module.exports = {
 
     // orientation: {
     //     valType: 'enumerated',
-    //     role: 'info',
     //     values: ['radial', 'angular'],
     //     editType: 'calc+clearAxisTypes',
     //     description: 'Sets the orientation of the bars.'

diff --git a/src/traces/streamtube/attributes.js b/src/traces/streamtube/attributes.js
@@ -95,7 +95,6 @@ var attrs = {
     //     valType: 'enumerated',
     //     values: ['scaled', 'absolute', 'fixed'],
     //     dflt: 'scaled',
-    //     role: 'info',
     //     editType: 'calc',
     //     description: [
     //         'Sets the mode by which the streamtubes are sized.'