adjust min and max positions of bars in respect to period alignment

plotly · Apr 29, 2021 · c96bf99 · c96bf99
1 parent 689adfa
commit c96bf99
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/traces/bar/hover.js b/src/traces/bar/hover.js
@@ -35,8 +35,22 @@ function hoverOnBars(pointData, xval, yval, hovermode) {
 
     var posVal, sizeVal, posLetter, sizeLetter, dx, dy, pRangeCalc;
 
-    function thisBarMinPos(di) { return di[posLetter] - di.w / 2; }
-    function thisBarMaxPos(di) { return di[posLetter] + di.w / 2; }
+    function thisBarMinPos(di) { return thisBarExtPos(di, -1); }
+    function thisBarMaxPos(di) { return thisBarExtPos(di, 1); }
+
+    function thisBarExtPos(di, sgn) {
+        var w = di.w;
+        var delta = sgn * w;
+        if(trace[posLetter + 'period']) {
+            var alignment = trace[posLetter + 'periodalignment'];
+            if(alignment === 'start') {
+                delta = (sgn === -1) ? 0 : w;
+            } else if(alignment === 'end') {
+                delta = (sgn === -1) ? -w : 0;
+            }
+        }
+        return di[posLetter] + delta / 2;
+    }
 
     var minPos = isClosest ?
         thisBarMinPos :