Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike position in unified hover mode #4716

Closed
emmanuelle opened this issue Mar 30, 2020 · 9 comments
Closed

Spike position in unified hover mode #4716

emmanuelle opened this issue Mar 30, 2020 · 9 comments
Labels
bug something broken

Comments

@emmanuelle
Copy link
Contributor

https://codepen.io/emmanuelle-plotly/pen/eYNxQba?editable=true (hover on the scatter point at x=0, the spike line stays at the middle of the bar)
image

@archmoj
Copy link
Contributor

archmoj commented Mar 9, 2021

Is this really a bug?

@alexcjohnson
Copy link
Collaborator

If there's a hover label, the spikeline should get its position from something within that label. In this case the bar is setting the spikeline position, but only the scatter point is in the hover label.

@nicolaskruchten
Copy link
Contributor

Definitely a bug, because it doesn't happen if the cursor or point is above the bar rather than within it.

@nicolaskruchten
Copy link
Contributor

Compare hovering over the scatter points within the two bars' ranges here: https://codepen.io/nicolaskruchten/pen/abZrYJO?editors=0010

@nicolaskruchten
Copy link
Contributor

Note that the behaviour in hovermode: "x" with xaxis.showspikes: true is also pretty bad: https://codepen.io/nicolaskruchten/pen/yLVQXYy?editors=0010

@nicolaskruchten
Copy link
Contributor

Can I see a pen with just this PR please so I can approve this one's behaviour separately from the other one? (it was nice to see them together as well, but now I'd like to see just this one broken out please :)

@archmoj
Copy link
Contributor

archmoj commented Mar 15, 2021

Can I see a pen with just this PR please so I can approve this one's behaviour separately from the other one? (it was nice to see them together as well, but now I'd like to see just this one broken out please :)

Here is a before vs after codepen.

@nicolaskruchten
Copy link
Contributor

✨ for the behaviour! just need a dancer from @alexcjohnson and then we can tackle #5292 on its own

@archmoj
Copy link
Contributor

archmoj commented Mar 16, 2021

#5542 is merged.
@nicolaskruchten you may close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

4 participants