Fixup bar spike distance #5542
Merged
Fixup bar spike distance #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/traces/bar/hover.js
Outdated
| // add a little to the pseudo-distance for wider bars, so that like scatter, | ||
| // if you are over two overlapping bars, the narrower one wins. | ||
| return Fx.inbox(_minPos - posVal, _maxPos - posVal, | ||
| maxSpikeDistance + Math.min(1, Math.abs(_maxPos - _minPos) / pRangeCalc) - 1); |
There was a problem hiding this comment.
If the only difference between spikePositionFn and hoverPositionFn is which max*Distance is used, just make that a 3rd arg to the _positionFn calls below.
Same with sizeFn vs thisBarSizeFn, looks like that could be a higher-order function like sizeFn(whichMaxDist)(di)
alexcjohnson
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4716.
@plotly/plotly_js