Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test to validate mocks #4733

Closed
archmoj opened this issue Apr 6, 2020 · 2 comments
Closed

Write test to validate mocks #4733

archmoj opened this issue Apr 6, 2020 · 2 comments

Comments

@archmoj
Copy link
Contributor

archmoj commented Apr 6, 2020

cc: #4707 (comment)

@alexcjohnson
Copy link
Collaborator

From #4762: before we consider this issue closed, new mocks must automatically be part of the validation test. IMO that's actually more important than making sure we validate all the existing mocks, though both parts would be useful.

My primary question is about the hard-coded list in mocks_test - seems like we should be able to

  • read in the list of all mocks from the filesystem - perhaps if this step is fast enough we can just have karma.conf.js do it before every test run and write the results to a file in tests/jasmine/assets?
  • only list a set of mocks or patterns to ignore - and then over time we can reduce that to an empty list.

@alexcjohnson
That is a very good idea we could try in another PR.
At first I did try to adapt our image test for this purpose.
But it was rather complicated to acess the system files from the jasmine test.

@gvwilson
Copy link
Contributor

Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants