-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock validation utility #5653
Mock validation utility #5653
Conversation
LGTM! Have you seen this fail on CI? ie just push a branch off this one with a purposely invalid addition to a mock, just to make sure it will properly flag failures for us. |
Good call. Tested locally and on the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Especially that we can switch from a whitelist to a blacklist (and hopefully over time cut that list down). 💃
Followup of #4762.
Addressing #4733.
Thanks to #5411, now we could
node.js
for our mock validation 🎉It is now feasible to run validation tests both locally namely when contributors add new mocks/features to the library, as well as on CircleCI.
While new script does not depend on
browserify
andjasmine
to resolve and load multiple files all at once, it is more robust now and could remove potential side effects of the previousmock_test
on parallel runs.Plus after adding a new mock, it would automatically be tested by this system when there is no need to add its name to the list.
Since we used to run this in
noci_test
right before publishing (and sometimes fail at final moments), the current setup should help reduce all the noise too.@plotly/plotly_js