Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no calendar on partial bundles #4883

Closed
mattcorner opened this issue May 28, 2020 · 4 comments · Fixed by #5422
Closed

no calendar on partial bundles #4883

mattcorner opened this issue May 28, 2020 · 4 comments · Fixed by #5422
Labels
bug something broken

Comments

@mattcorner
Copy link

I am trying to get the connectgaps property to work in a React app where I use a custom plotly.js bundle to reduce the build size.

With this custom bundle which imports only Surface, connectgaps does not work.

If I use the full plotly.js bundle, the plot works properly.

See attached github repo for a simple reproduction showing the two plots side-by-side.
image
Github repo for reproduction

I presume that I either need to import something extra in the custom bundle, or that lib/Surface is missing a dependency?

@archmoj
Copy link
Contributor

archmoj commented May 28, 2020

Thanks for reporting. Here is a codepen illustrating the bug.
That's possibly related to surface trace using a function from heatmap trace.

@archmoj archmoj added the bug something broken label May 28, 2020
@archmoj archmoj changed the title Surface "connectgaps" not working with custom bundle no calendar on partial bundle Jun 2, 2020
@archmoj
Copy link
Contributor

archmoj commented Jun 2, 2020

@alexcjohnson strangely there is no calendar attached to axes when using partial gl3d bundle: demo.

@archmoj archmoj changed the title no calendar on partial bundle no calendar on partial bundles Jun 2, 2020
@archmoj
Copy link
Contributor

archmoj commented Jun 2, 2020

Not only gl3d but also other partial bundles e.g. gl2d & basic are also impacted by this bug: demo.

@archmoj
Copy link
Contributor

archmoj commented Jun 2, 2020

To clarify how calendar issue is linked to surface.connectgaps issue,
calendar is undefined here when using partial bundle:

rawCoords[2][j][k] = this.getZat(j, k, data.zcalendar, sceneLayout.zaxis);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants