Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include calendars in all bundles #5422

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Include calendars in all bundles #5422

merged 2 commits into from
Jan 20, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 19, 2021

Fixes #4883.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jan 19, 2021
@archmoj archmoj added this to the NEXT milestone Jan 19, 2021
lib/register_extra.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice simplification, to put all the common extras in one new file. Nice and 🌴 without stopping anyone from making their own bundle picking just a few of the extras. 💃

@archmoj
Copy link
Contributor Author

archmoj commented Jan 20, 2021

Interestingly I get an error right after 1fc1c03
cc: #5382 now in mapbox bundle.

Screenshot from 2021-01-19 19-15-50

@alexcjohnson
Do you mind if I revert that commit back to the functional form?

I think we need to deal with this kind of problems, until we could start using d3-geo cc: #5112.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 20, 2021

Interestingly I get an error right after 1fc1c03
cc: #5382 now in mapbox bundle.

Screenshot from 2021-01-19 19-15-50

@alexcjohnson
Do you mind if I revert that commit back to the functional form?

I think we need to deal with this kind of problems, until we could start using d3-geo cc: #5112.

I also suspect that the issue is caused by https://github.com/plotly/plotly.js/blob/master/tasks/compress_attributes.js

@archmoj
Copy link
Contributor Author

archmoj commented Jan 20, 2021

I also suspect that the issue is caused by https://github.com/plotly/plotly.js/blob/master/tasks/compress_attributes.js

In that case #5425 may help fix the problem for now.

@alexcjohnson
Copy link
Collaborator

I also suspect that the issue is caused by https://github.com/plotly/plotly.js/blob/master/tasks/compress_attributes.js

Great idea - that's actually plausible! Regardless, it's clear any change could make it reappear until we fix the root cause. So let's see what happens after #5425 is merged, but if and when it pops up again I think we should dig into it rather than working around it.

@archmoj archmoj merged commit 59390cb into master Jan 20, 2021
@archmoj archmoj deleted the calendars-in-bundles branch January 20, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no calendar on partial bundles
2 participants