You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any reason the last line isn't just return v;? This is a pretty hot function. After already filtering out non-numeric values and converting others to Number explicitly, why would we have to check isNumeric again?
This is
ensureNumber
:plotly.js/src/lib/index.js
Lines 166 to 171 in 8cccacc
Any reason the last line isn't just
return v;
? This is a pretty hot function. After already filtering out non-numeric values and converting others toNumber
explicitly, why would we have to checkisNumeric
again?Originally posted by @alexcjohnson in #5622 (comment)
The text was updated successfully, but these errors were encountered: