Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify ensureNumber #5637

Merged
merged 1 commit into from
May 5, 2021
Merged

simplify ensureNumber #5637

merged 1 commit into from
May 5, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 5, 2021

Closes #5634

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone May 5, 2021
@archmoj archmoj requested a review from alexcjohnson May 5, 2021 19:51
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃
Sad to see the encoding issue pop up again though 🤯

@archmoj archmoj merged commit 9a583b4 into master May 5, 2021
@archmoj archmoj deleted the simplify-ensure-number branch May 5, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify Lib.ensureNumber
2 participants