Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapbox-gl requirement #2029

Closed
wants to merge 1 commit into from
Closed

Update mapbox-gl requirement #2029

wants to merge 1 commit into from

Conversation

pfhayes
Copy link

@pfhayes pfhayes commented Sep 21, 2017

mapbox-gl 0.22.1 is very old and transitively
pulls in a vulnerable version of concat-stream.
See https://snyk.io/vuln/npm:concat-stream:20160901

@etpinard
Copy link
Contributor

See #1714

Thanks.

@alexcjohnson
Copy link
Collaborator

@etpinard Is #1972 going to make this upgrade possible?

@etpinard
Copy link
Contributor

@etpinard Is #1972 going to make this upgrade possible?

yes.

@etpinard
Copy link
Contributor

Update:

  • Remember that newer mapbox-gl versions are incompatible with the nw.js version we're using in our image-testing framework as well as on the plot.ly image server. Unfortunately, updating our image-testing framework didn't go as planned in Image testing with image-exporter electron runner #1972. In brief, I can't get our docker container to output the same pixels locally and on CI.
  • That said, in the meantime, perhaps someone would be interested (maybe @pfhayes 😏 ) in fixing our mapbox jasmine tests npm run test-jasmine -- *mapbox*. I did this back in Scattermapbox BADNUM + [email protected] #1543 for [email protected]. Hopefully nothing has change too much in mapbox-gl since that time.

@etpinard etpinard mentioned this pull request Feb 12, 2018
2 tasks
@etpinard
Copy link
Contributor

Superseded by #2361

@etpinard etpinard closed this Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants