Implement cliponaxis: false for bar text
#2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... now that the barlayer also supports `cliponaxis: false`
we let bar/plot.js handle clipping per trace.
src/components/drawing/index.js
Outdated
| if(!subplot._hasClipOnAxisFalse) return; | ||
|
|
||
| selector = selector || '.point,textpoint'; |
There was a problem hiding this comment.
'.point,.textpoint' (you lost a .)
There was a problem hiding this comment.
do we not have an image test that catches this?
There was a problem hiding this comment.
No. That thing only gets called during pan and scroll zoom. Nice catch. I'll add a pan test to 🔒 this down.
There was a problem hiding this comment.
Fixed and 🔒 in -> b9513a2
|
Very nice, relieves one of the big pain points until we really do text in autorange. 💃 |
|
YESSSSSSSSSS! Love Friday Afternoon Features 🥇 |
|
Oo |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friday Afternoon Feature. This one was talked about in #2000 and #2001 as one way to solve problems with undesired clipped text nodes in bar traces. Note that this PR does not attempt to make on-graph text contribue to the autorange computations.
cc @alexcjohnson @cldougl (and I think this should make @chriddyp happy too 😉 )