Z exponent fix #2422
Merged
Z exponent fix #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Feb 28, 2018
| @@ -1528,7 +1528,7 @@ function numFormat(v, ax, fmtoverride, hover) { | |||
| if(hover) { | |||
| // make a dummy axis obj to get the auto rounding and exponent | |||
| var ah = { | |||
| exponentformat: ax.exponentformat, | |||
| exponentformat: exponentFormat, | |||
etpinard
reviewed
Feb 28, 2018
| ['123.4568', '12.34568B', expFmt('1', 23)] | ||
| ] | ||
| .forEach(function(row, y) { | ||
| row.forEach(function(zVal, x) { |
There was a problem hiding this comment.
✨ test! Why create 12 test cases when we can loop over 12 bricks!
|
💃 nicely done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2420 - #2106 improved formatting here but broke the default behavior for z values that need exponents. Fortunately the fix was a one-liner.
cc @etpinard