Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacking of centered hover info elements #865 #2445

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

rmoestl
Copy link
Contributor

@rmoestl rmoestl commented Mar 6, 2018

This fixes #865: boxes of multiple centered hover info elements had all the same vertical position, hence hiding each other and not "following" associated text labels in terms of positioning.

Final solution:
865_stacked_centered_hover_info_elements

- Bug: boxes of multiple centered hover info elements had
  all the same vertical position, hence hiding each other,
  not "following" associated text labels in terms of
  positioning.
@rmoestl rmoestl added the bug something broken label Mar 6, 2018
@rmoestl rmoestl self-assigned this Mar 6, 2018
@rmoestl rmoestl requested review from alexcjohnson and etpinard March 6, 2018 10:51
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Always annoying when a one-line fix takes 100 lines to test, but that's how it goes. 💃

@rmoestl rmoestl merged commit 161b602 into master Mar 6, 2018
@etpinard etpinard deleted the fix-centered-hover-info-elems-stacked branch March 6, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover label elements are misplaced on small viewports
2 participants