Bundle with browser-pack-flat plugin #2447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice benefit from removing all circular deps in #2429,
browser-pack-flat
now allows us to trim some bundle bits (especially in our minified bundle).Here's what
browser-pack-flat
can trim:that's about 10 gzip+minified
kB
per bundle. Not bad I think.That said, using
browser-pack-flat
comes at a price 💰 ,npm run build
is not a bit slower and consumes a lot more memory. So I had to userun-series
to reduce memory consumption and makenpm run build
succeed consistently. Note also, I thinking of only usingbrowser-pack-flat
duringnpm run build
to not slownpm run watch
andnpm start
.Referencing https://github.com/plotly/plotly-webpack/issues/2 that first discussed bundling with
browser-pack-flat
.