Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category angular axis mocked range logic #2449

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Fix category angular axis mocked range logic #2449

merged 1 commit into from
Mar 7, 2018

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Mar 6, 2018 •
edited
Loading

fixes #2421

  • 🔪 useless axex.expand call in scatterpolar/calc, this is an artefact from an earlier angular dates attempt
  • set mocked angular axis range using max of set 'period' and total categories length.
  • more on period vs category limitations and possible improvements in Polar 2.0 open items #2255

cc @alexcjohnson

@etpinard
fix and 🔒 category angular axis mocked range logic
2eeab9f 
- 🔪 useless axex.expand call in scatterpolar/calc, this
  is an artefact from an earlier angular dates attempt
- set mocked angular axis range using max of set 'period' and
  total categories length.
- more on period vs category in #2255
@etpinard etpinard added bug something broken status: reviewable labels Mar 6, 2018
@alexcjohnson
Copy link
Collaborator

Nice job. 💃

@etpinard etpinard merged commit d55a1be into master Mar 7, 2018
@etpinard etpinard deleted the polar-category-range-fix branch March 7, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scatterpolar bug: not all theta labels showing
2 participants
@etpinard @alexcjohnson