Fix shift selection after pan #2676
Conversation
src/plots/cartesian/dragbox.js
Outdated
| @@ -178,6 +178,8 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) { | |||
| prepSelect(e, startX, startY, dragOptions, dragModeNow); | |||
| } else { | |||
| dragOptions.clickFn = clickFn; | |||
| // clear selection polygon cache (if any) | |||
| plotinfo.selection = false; | |||
There was a problem hiding this comment.
Should this be part of clearSelect? That gets called in all 3 blocks below (directly in the first and third, and in the second it's inside zoomPrep - looks like these can be simplified anyway) but also in zoomWheel - does that case have the same bug?
There was a problem hiding this comment.
Ah. Good catch. Zoom has the problem.
Working on a fix ⛏️
There was a problem hiding this comment.
fixed and 🔒 in f682fb8
src/plots/cartesian/dragbox.js
Outdated
| if(redrawTimer === null) { | ||
| clearSelect(zoomlayer); | ||
| } | ||
| clearSelect(zoomlayer); |
There was a problem hiding this comment.
this fixes what I botched in 51c3128
src/plots/cartesian/dragbox.js
Outdated
| @@ -196,11 +194,18 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) { | |||
| } else if(dragModeNow === 'pan') { | |||
| dragOptions.moveFn = plotDrag; | |||
| dragOptions.doneFn = dragTail; | |||
| clearSelect(zoomlayer); | |||
| clearAndResetSelect(); | |||
There was a problem hiding this comment.
Again, every branch here contains clearAndResetSelect (and this is the only caller of zoomPrep) so it can be factored out into just one call.
There was a problem hiding this comment.
Ooops, I missed the one in zoomPrep. Cleaned up in -> 34a0cf7
|
Fantastic. Really nice tests BTW! 💃 |
Fixes #2669
before:
now:
cc @alexcjohnson