Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mapbox minification fix #2792

Merged
merged 8 commits into from
Jul 11, 2018
Merged

Better mapbox minification fix #2792

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1f1e47c
undo 'typeofs' compress for min bundles that include mapbox-gl
etpinard Jul 9, 2018
7171bc4
add minified bundle test
etpinard Jul 9, 2018
2a3afe7
turn off 'typeof' compress options for all minify steps
etpinard Jul 9, 2018
dd8bf6c
extract all mock lists from plot_api suites
etpinard Jul 9, 2018
89d7aa8
use mock list in minified bundle suite
etpinard Jul 9, 2018
9ba473d
run test-bundle in series
etpinard Jul 10, 2018
d1992b4
try adding long timeout (for mapbox)
etpinard Jul 10, 2018
810e91f
move test-bundle to jasmine test container
etpinard Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ case $1 in

jasmine)
npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
npm run test-bundle || EXIT_STATE=$?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which gives:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚖️ 👍
💃 still applies :)

exit $EXIT_STATE
;;

jasmine2)
retry npm run test-jasmine -- --tags=gl --skip-tags=noCI,flaky
retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
npm run test-bundle || EXIT_STATE=$?
exit $EXIT_STATE
;;

Expand Down