Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend for traces with typed array marker.size #3192

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

etpinard
Copy link
Contributor

fixes #3179

cc @plotly/plotly_js

@etpinard etpinard added bug something broken status: reviewable labels Oct 31, 2018
@etpinard etpinard changed the title Fix legend for trace with typed array marker.size Fix legend for traces with typed array marker.size Oct 31, 2018
@alexcjohnson
Copy link
Collaborator

Nice'n'easy. Beautiful test. 💃

@etpinard etpinard merged commit 458f593 into master Oct 31, 2018
@etpinard etpinard deleted the typed-array-marker-size-legend-fix branch October 31, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter marker missing from legend when marker.size is specified as TypedArray
2 participants