Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix2950 parcoords cannot select first enum #3915

Merged
merged 2 commits into from
May 28, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 28, 2019

Fix for #2950 and https://github.com/plotly/phoenix-integration/issues/201.

The bug was introduced at this line; whereas i === 1 should have been applied.

if(v > aNext || i === a.length - 1) return snapOvershoot(aNext, aPrev);

The logic within low and high functions are also refactored and merged into one function.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 28, 2019
@etpinard
Copy link
Contributor

Nice fix and cleanup!

💃


Does this also fix #3794 ?

@archmoj archmoj merged commit 7c28505 into master May 28, 2019
@archmoj archmoj deleted the fix2950-parcoords-cannot-select-first-enum branch May 28, 2019 02:25
@archmoj archmoj added this to the v1.48.0 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants