Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ScatterGL hover and click events give the 'top' point instead of the 'bottom' point #3924

Merged
merged 2 commits into from
May 31, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 31, 2019

Fix for https://github.com/plotly/phoenix-integration/issues/241 i.e. in mode: closest.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 31, 2019
@etpinard
Copy link
Contributor

Brilliant fix and test 💃

@archmoj archmoj merged commit 297ecb7 into master May 31, 2019
@archmoj archmoj deleted the phx-241 branch May 31, 2019 14:07
@secretwpn
Copy link

Hi!
I was about to open an issue about this, but tried to search first and came across this issue.

Currently if I have a bunch of scattergl traces with hovermode: closest and there is a cluster of overlapping points,
the plotly_click event handler will get only the "bottom of the stack" point, which is completely counter-intuitive - if the point is rendered on the top (closest to user) - I expect this point to come with an event, not the one that is buried under the whole stack.

But apparently this is an intended behavior coming from this fix?

What is the reason for this?
Is there any way to get the topmost point from the event?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants