Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump more dependencies - edition 2019 June 11 #3952

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 12, 2019

Bump es6-promise and topojson-client;
Uninstall font-atlas-sdf i.e. an unused dependency.

@plotly/plotly_js

Correction:
No es6-promise and topojson-client in this PR.
Only removing font-atlas-sdf dependency here.

@etpinard
Copy link
Contributor

Thanks, but we can't just bump those.

Bumping es6-promise is a breaking change (they don't have the same browser support if I remember correctly, cc #2466)

topojson-client also does something different, it uses a bunch more memory and makes geo subplot slower we tried it when working on #3856

@etpinard
Copy link
Contributor

etpinard commented Jun 14, 2019

Only removing font-atlas-sdf dependency here.

Good eye. We swaped out font-atlas-sdf for svg-path-sdf during the regl scattergl push #2258

💃 thanks!

@archmoj
Copy link
Contributor Author

archmoj commented Jun 14, 2019

@etpinard Awesome.
Thanks for finding out the reason why it was useful.

@archmoj archmoj merged commit 0690162 into master Jun 14, 2019
@archmoj archmoj deleted the bump-more-deps-june-11 branch June 14, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants