Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 0 in grouby transform nameformat templates + fix Plotly.validate for valType:'any' attributes #4526

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

etpinard
Copy link
Contributor

Commit c7dd66a fixes #4497

before (see missing legend item): https://codepen.io/etpinard/pen/VwYOevV
after: https://codepen.io/etpinard/pen/QWwRyyN

Commit 098ced5 fixes #4496

before (open the console to see validate logs): https://codepen.io/etpinard/pen/RwNmrWd
after: https://codepen.io/etpinard/pen/mdyYVPY

cc @archmoj

@etpinard etpinard added bug something broken status: reviewable labels Jan 28, 2020
@archmoj
Copy link
Contributor

archmoj commented Jan 28, 2020

@etpinard thanks very much.
Nicely done.
💃 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group By legend item missing for TypedArray if target == 0 Group By example produces schema error
2 participants