Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waterfall 'closest' hover when cursor is below the size axis #4537

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard added bug something broken status: reviewable labels Jan 31, 2020
@archmoj
Copy link
Contributor

archmoj commented Jan 31, 2020

@etpinard thanks for the PR!
Any idea why the hover does not show up on the very first bar?

@etpinard
Copy link
Contributor Author

Try now: https://codepen.io/etpinard/pen/oNgrJYq

@archmoj
Copy link
Contributor

archmoj commented Jan 31, 2020

Nicely done.
💃

@etpinard
Copy link
Contributor Author

Ok thanks for the review. I'll wait before you have a look at the treemap_coffee problem before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click events for waterfall charts not aligned
2 participants