Fix 3-D config for webgl buffer on iPad Pro & iPad 7th + iOs v13 + Safari #4546
Conversation
| @@ -82,7 +82,7 @@ | |||
| "gl-mat4": "^1.2.0", | |||
| "gl-mesh3d": "^2.3.0", | |||
| "gl-plot2d": "^1.4.3", | |||
| "gl-plot3d": "^2.4.1", | |||
| "gl-plot3d": "^2.4.2", | |||
| result === false && | ||
| userAgent.indexOf('Macintosh') !== -1 && | ||
| userAgent.indexOf('Safari') !== -1 && | ||
| navigator.maxTouchPoints > 1 |
There was a problem hiding this comment.
How did you find this solution?
There was a problem hiding this comment.
src/plots/gl3d/scene.js
Outdated
| var tablet = isTablet(); | ||
|
|
||
| function isTablet() { | ||
| var navigator = window.navigator; |
There was a problem hiding this comment.
Does is-mobile setup a guard for cases when window.navigator is undefined?
There was a problem hiding this comment.
I don't see any check there concerning navigator.
There was a problem hiding this comment.
OK, can you add one just to be sure?
There was a problem hiding this comment.
(I wouldn't someone running plotly.js in some sort of weird environment have their app break in a patch release)
There was a problem hiding this comment.
Actually it is added in 436fca4 here:
if(!ua && typeof navigator !== 'undefined') ua = navigator.userAgent;There was a problem hiding this comment.
Sure, we can still get breakage on this line below:
navigator.maxTouchPoints > 1if window.navigator isn't defined.
There was a problem hiding this comment.
Addressed in aa28eba.
src/plots/gl3d/scene.js
Outdated
|
|
||
| function isTablet() { | ||
| var navigator = window.navigator; | ||
| var userAgent = navigator.userAgent; |
There was a problem hiding this comment.
and similarly here, if is-mobile guards against undefined navigator.userAgent, we should too here.
|
Sweet. Thanks very much 💃 - once tests pass! |
|
@etpinard Thanks for the review. |
PR to |
Fixes #4502 | Demo
@plotly/plotly_js
cc: @jackparmer