Detect correct device in the second attempt to create 3-D scene #4549
Conversation
- no need to rebuild options to avoid webgl context loss on multi-scene layouts
| } else { // try second time | ||
| try { | ||
| // invert preserveDrawingBuffer setup which could be resulted from is-mobile not detecting the right device | ||
| isMobile = opts.glOptions.preserveDrawingBuffer = !opts.glOptions.preserveDrawingBuffer; |
There was a problem hiding this comment.
Hmm, I'm not sure I like this.
If the "main" problem here is is-mobile not doing its job in some cases, then we should try to fix is-mobile instead of working around it behind the scenes.
At the very (very) least we should Lib.warn something here to let the user (and the devs) know what's going on, and gather some data on the situations where is-mobile is buggy.
To be more robust, what if instead of flipping preserveDrawingBuffer here, we allow users (via a new config option) to set preserveDrawingBuffer to true to essentially override is-mobile when they want?
There was a problem hiding this comment.
To be more robust, what if instead of flipping
preserveDrawingBufferhere, we allow users (via a new config option) to setpreserveDrawingBuffertotrueto essentially overrideis-mobilewhen they want?
The users may not know in advance the correct setup for the devices.
There was a problem hiding this comment.
Hmm, I'm not sure I like this.
If the "main" problem here is
is-mobilenot doing its job in some cases, then we should try to fixis-mobileinstead of working around it behind the scenes.
At the very (very) least we should
Lib.warnsomething here to let the user (and the devs) know what's going on, and gather some data on the situations whereis-mobileis buggy.
Good call. Done in a26e5e2.
There was a problem hiding this comment.
The users may not know in advance the correct setup for the devices.
Yes, I know that. But do you agree that the best way to fix this problem would be to fix is-mobile?
There was a problem hiding this comment.
.... but now with the Lib.warn message I guess we can expect some users to tell us about it - which may lead us to fix is-mobile for these cases.
I'm happy with this solution. That Lib.warn message is very clear.
There was a problem hiding this comment.
I totally agree we should try fixing is-mobile to help detect the right device.
Still this PR helps detect/by-pass such edge cases.
|
💃 |
|
I'm running 1.54.2 but it's still an issue. |
Follow up of and 4546 and #4548, and in regards with a number of comments from users experiencing webgl setup e.g.
#3640 (comment)
#3640 (comment)
#3640 (comment)
#3640 (comment)
this PR uses a different webgl config for
preserveDrawingBufferin the second attempt to creategl3dscene. With this in place the graph should be displayed instead of a webgl error namelyError: WebGL warning: checkFramebufferStatus: Framebuffer not completeeven if
is-mobilemodule was unable to detect the correct device.Demo
@plotly/plotly_js
cc: @hoerup